[incubator-echarts] branch typescript updated: fix: typo and type

[sushuang]

This is an automated email from the ASF dual-hosted git repository.

sushuang pushed a commit to branch typescript
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git


The following commit(s) were added to refs/heads/typescript by this push:
     new 9134faa  fix: typo and type
9134faa is described below

commit 9134faa00cf2b6721e6d7cd90b706e0a00f08f07
Author: 100pah <sushuang0...@gmail.com>
AuthorDate: Wed Mar 4 15:52:26 2020 +0800

    fix: typo and type
---
 src/data/helper/dataProvider.ts    | 2 +-
 src/data/helper/dataStackHelper.ts | 4 ++--
 src/model/Series.ts                | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/data/helper/dataProvider.ts b/src/data/helper/dataProvider.ts
index 6893e2a..599f78c 100644
--- a/src/data/helper/dataProvider.ts
+++ b/src/data/helper/dataProvider.ts
@@ -82,7 +82,7 @@ export class DefaultDataProvider implements DataProvider {
 
     constructor(sourceParam: Source | OptionSourceData, dimSize?: number) {
         // var source: Source;
-        var source: Source = !(source instanceof Source)
+        var source: Source = !(sourceParam instanceof Source)
             ? Source.seriesDataToSource(sourceParam as OptionSourceData)
             : sourceParam as Source;
 
diff --git a/src/data/helper/dataStackHelper.ts 
b/src/data/helper/dataStackHelper.ts
index 8f34537..cc0fac1 100644
--- a/src/data/helper/dataStackHelper.ts
+++ b/src/data/helper/dataStackHelper.ts
@@ -53,7 +53,7 @@ interface DataStackResult {
  */
 export function enableDataStack(
     seriesModel: SeriesModel<SeriesOption & SeriesStackOptionMixin>,
-    dimensionInfoList: DataDimensionInfo[],
+    dimensionInfoList: (DataDimensionInfo | string)[],
     opt?: {
         stackedCoordDimension?: string
         byIndex?: boolean
@@ -116,7 +116,7 @@ export function enableDataStack(
         var stackedDimType = stackedDimInfo.type;
         var stackedDimCoordIndex = 0;
 
-        each(dimensionInfoList, function (dimensionInfo) {
+        each(dimensionInfoList, function (dimensionInfo: DataDimensionInfo) {
             if (dimensionInfo.coordDim === stackedDimCoordDim) {
                 stackedDimCoordIndex++;
             }
diff --git a/src/model/Series.ts b/src/model/Series.ts
index a1954cc..b061a54 100644
--- a/src/model/Series.ts
+++ b/src/model/Series.ts
@@ -330,7 +330,7 @@ class SeriesModel<Opt extends SeriesOption = SeriesOption> 
extends ComponentMode
     ): {
         html: string,
         markers: {[markName: string]: string}
-    } | string { // The override method can only return string
+    } | string { // The override method can also return string
 
         var series = this;
         renderMode = renderMode || 'html';


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org