chfw commented on a change in pull request #13833:
URL:
https://github.com/apache/incubator-echarts/pull/13833#discussion_r546966218
##########
File path: src/layout/barGrid.ts
##########
@@ -441,14 +466,40 @@ function retrieveColumnLayout(
}
export {retrieveColumnLayout};
+function orderLayoutData(layoutInfo: layoutInfo) {
+ const groupOrder = layoutInfo.groupOrder;
+ let layoutDataList = layoutInfo.layoutDataList;
+ let columnOffsetList = layoutInfo.columnOffsetList;
+ columnOffsetList.sort(function (a, b) {
+ return a - b;
+ });
Review comment:
Since the love of anonymous function is shown here, I would suggest to
make this anonymous function really compact:
columnOffsetList.sort((a, b) => a-b )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
