JackHlw commented on a change in pull request #13833:
URL:
https://github.com/apache/incubator-echarts/pull/13833#discussion_r547182271
##########
File path: src/layout/barGrid.ts
##########
@@ -464,26 +515,77 @@ export function layout(seriesType: string, ecModel:
GlobalModel) {
lastStackCoords[stackId] = lastStackCoords[stackId] || [];
+ layoutInfo.groupOrder = seriesModel.get('groupOrder');
+ columnOffsetList[seriesIndex] = columnOffset;
+
data.setLayout({
bandWidth: columnLayoutInfo.bandWidth,
offset: columnOffset,
size: columnWidth
});
-
const valueDim = data.mapDimension(valueAxis.dim);
const baseDim = data.mapDimension(baseAxis.dim);
const stacked = isDimensionStacked(data, valueDim /*, baseDim*/);
const isValueAxisH = valueAxis.isHorizontal();
const valueAxisStart = getValueAxisStart(baseAxis, valueAxis, stacked);
-
+ let dataToPointList: number[];
for (let idx = 0, len = data.count(); idx < len; idx++) {
Review comment:
'data' is not an array, it just uses the length obtained by `data.count
()` for data collection, and `for(let idx in data){` cannot be used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
