Ovilia commented on a change in pull request #15095:
URL: https://github.com/apache/echarts/pull/15095#discussion_r647379047
##########
File path: src/processor/negativeDataFilter.ts
##########
@@ -0,0 +1,44 @@
+import { StageHandler } from '../util/types';
Review comment:
This should appear after the license header.
##########
File path: test/pie-minus-value.html
##########
@@ -0,0 +1,105 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<html>
+ <head>
+ <meta charset="utf-8" />
+ <script src="lib/simpleRequire.js"></script>
+ <script src="lib/config.js"></script>
+ <meta name="viewport" content="width=device-width, initial-scale=1" />
+ </head>
+ <body>
+ <style>
+ h1 {
+ line-height: 60px;
+ height: 60px;
+ background: #146402;
+ text-align: center;
+ font-weight: bold;
+ color: #eee;
+ font-size: 14px;
+ }
+ .chart {
+ height: 600px;
+ }
+ </style>
+
+ <div id="main" class="chart"></div>
+ <script>
+ require(["echarts"], function (echarts) {
+ var chart = echarts.init(document.getElementById("main"));
+
+ chart.setOption({
+ aria: {
+ enabled: true,
+ },
+ title: {
+ text: `The minus value slice should render like 0
value,
+ while the tooltip should show the origin minus value`,
+ x: "center",
+ },
+ tooltip: {
+ trigger: "item",
+ formatter: "{a} <br/>{b} : {c} ({d}%)",
+ },
+ legend: {
+ orient: "vertical",
+ left: "left",
+ data: [
+ "直接访问",
+ "邮件营销",
+ "联盟广告",
+ "视频广告(value is 0)",
+ "搜索引擎(value is minus)",
+ ],
+ },
+ series: [
+ {
+ name: "访问来源",
+ type: "pie",
+ radius: "55%",
+ center: ["50%", "60%"],
+ selectedMode: "single",
+ data: [
+ { value: 335, name: "直接访问" },
Review comment:
As @plainheart suggested, I think we should add a test case that all
data are negative.
##########
File path: src/chart/pie/pieLayout.ts
##########
@@ -30,9 +30,9 @@ const RADIAN = Math.PI / 180;
function getViewRect(seriesModel: PieSeriesModel, api: ExtensionAPI) {
return layout.getLayoutRect(
seriesModel.getBoxLayoutParams(), {
- width: api.getWidth(),
- height: api.getHeight()
- }
+ width: api.getWidth(),
+ height: api.getHeight()
+ }
Review comment:
I think these three lines (or perhaps this file?) should not be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
