Ovilia commented on PR #17426: URL: https://github.com/apache/echarts/pull/17426#issuecomment-1200834745
@pissang I'm not quite sure about if it's proper to make a done callback for group animations. Please help review again. Also, current implementation doesn't consider the case when axis doesn't have animation. Should I check `axisModel` to get if there is animation and call `setGroupSubPixelOptimize` if not? This feels a little strange to me so I would like to hear about your opinion first and then make a thorough test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
