Re: [PR] fix(grid): respect axisLabel.width when containLabel is true [echarts]

Thu, 11 Dec 2025 22:43:09 -0800 


Justin-ZS commented on PR #21392:
URL: https://github.com/apache/echarts/pull/21392#issuecomment-3645143654

   > i tried to reproduce
   > 
   > > I tried the 
[demo](https://echarts.apache.org/examples/zh/editor.html?c=line-simple&code=TVK7TsMwFN35irsFJBQlRQgUxAADE1uRGBCD25rUwsSV61AqhMQCZYCBgZfEQ0KCjXZCqgqlP9NE7dRfwHZcp0Nu7rk-Pvfhy2qCsAjW4XQOIOSkEmgPgOIDEYC3qIFgNeuXmBDsyMIyiwQi0TYqYRqA4DFW8TNlmhsnpD7VQ9I3pCwgQ5SEUQAOJ2FVOJkcQINURDUA3zMJANgx5geUNSRV6kdlJLBlY0pJra7SOK7rmrDMnpXdrGF5oC6EjDfNaQUJFMCeEXBGg6e0_T3qvCSt3rB3OX5oj98fJ7_X6dVt-vyW_F3Mdji-GyS9z-HPB0wGfd2faxtzdeUw7PaS1uXo_HrYvUkfO5KbtF_HTxfpfSv5ekjafSWgObYJZxdXcrBTjXOwxUkOiigfk1OMIwP27cRPZiduuj9GNM7mpSl1zAmWnKz_6VOYmfgFbxEKcvLgL0uzKr8VBXxlljydaEa6hLitp15ljU1UPgw5iyO5RdNN0Ctj40XRpPLmNK1aH8q42oGwhOZ9lTA3nltYsPq6ePOTdZyt_QM&enc=deflate)
 in #16111, and it seems to work as expected on my end. Could you provide more 
details about the issue you're experiencing?
   > 
   > When grid.containLabel was set to true and yAxis.axisLabel.width was 
configured with overflow: 'truncate', the grid layout calculation incorrectly 
used the actual text width instead of the configured width value. This caused 
the grid to reserve too much space for axis labels, resulting in incorrect 
chart layout.
   > 
   > before the fix <img alt="line-simple (3)" width="1057" height="701" 
src="https://private-user-images.githubusercontent.com/173557181/525357882-fb3baf4d-d349-40f2-aee2-0af06ec7ed8b.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjU1MjE3MjEsIm5iZiI6MTc2NTUyMTQyMSwicGF0aCI6Ii8xNzM1NTcxODEvNTI1MzU3ODgyLWZiM2JhZjRkLWQzNDktNDBmMi1hZWUyLTBhZjA2ZWM3ZWQ4Yi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUxMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MTIxMlQwNjM3MDFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jZWE0MmU1NzAzOTgzZDRjYjA1ZTIwZjUzMjkwOTJjYWUxMzIyMDRjZWI2YzI3NzcwZWRjMmJlZjQ2MjY5OWUzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.et5GPU-2uK4RYb5HtgpwrOjwnbqtmz8nY7iuSZkuC4U";>
 after the fix you can see the right side of label <img alt="Screenshot 
2025-12-11 172348" width="999" height="757" src="https://private-u
 
ser-images.githubusercontent.com/173557181/525358111-36490d17-c421-47ac-a6fb-58dae25f5162.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjU1MjE3MjEsIm5iZiI6MTc2NTUyMTQyMSwicGF0aCI6Ii8xNzM1NTcxODEvNTI1MzU4MTExLTM2NDkwZDE3LWM0MjEtNDdhYy1hNmZiLTU4ZGFlMjVmNTE2Mi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUxMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MTIxMlQwNjM3MDFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yNjYxZTEzMjg2NDg0ZTgwNjQ1NGM4YzcyZDg0YzUxZmE1ZmI2ZTVhNGE3YTU3Y2UwOWRmZjllYzUzMThjYjE4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Mq22YSgy4JmdY-ZDIfoJw9cQXjZvMeEXtqu0HoFk-VU">
   
   This caused the grid to reserve **too much space** for axis labels, 
resulting in incorrect chart layout.
   I can't find any extra blank spaces. Could you add some markers to emphasize 
the incorrect blank spaces?
   <img width="291" height="194" alt="截屏2025-12-12 14 42 44" 
src="https://github.com/user-attachments/assets/6f42d3b7-3a14-445f-be58-5daa7f840651";
 />
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to