vidakovic commented on code in PR #3321:
URL: https://github.com/apache/fineract/pull/3321#discussion_r1281102732
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseSpecificSQLGenerator.java:
##########
@@ -189,4 +207,49 @@ public String castJson(String sql) {
throw new IllegalStateException("Database type is not supported
for casting to json " + databaseTypeResolver.databaseType());
}
}
+
+ public static String alias(@NotNull String field, String alias) {
Review Comment:
Just looking at all these functions in general (not only Marta's): this is
getting more and more complex... a fight we cannot win.... and in the end we
have compatibility for 2 database systems. A lot of work (also future
maintenance). Why not hit the breaks here and use e. g. JOOQ. Slowly, but
steadily we are recreating it here with less features and less supported
databases. For another day to decide, but I think it will be an important
improvement.... and all this code can go away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
