vidakovic commented on code in PR #3321:
URL: https://github.com/apache/fineract/pull/3321#discussion_r1281113631
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseTypeResolver.java:
##########
@@ -58,10 +58,10 @@ public DatabaseType databaseType() {
}
public boolean isPostgreSQL() {
- return DatabaseType.POSTGRESQL.equals(currentDatabaseType.get());
+ return DatabaseType.POSTGRESQL == currentDatabaseType.get();
Review Comment:
I guess my point is: you can iterate over all values of an enum or use it
for example in a switch statement... those "is..." functions you can only use
in (ugly) if-then-else-if statements.... I think this style has a tendency to
bloat code...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
