marta-jankovics commented on code in PR #3321:
URL: https://github.com/apache/fineract/pull/3321#discussion_r1281670436
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseSpecificSQLGenerator.java:
##########
@@ -36,14 +42,26 @@ public DatabaseSpecificSQLGenerator(DatabaseTypeResolver
databaseTypeResolver) {
}
public String escape(String arg) {
- if (databaseTypeResolver.isMySQL()) {
+ return escape(databaseTypeResolver.databaseType(), arg);
+ }
+
+ public static String escape(DatabaseType dialect, String arg) {
Review Comment:
The dialect parameter might not be used for the currently supported dialects
but will be needed for the next supported one, that is why this class has a
reference to the dialect.
You can not instantiate a component, only from a component (mainly) so if
not static then a parameter of the SqlGenerator component for every method in
the call chain. That would be another solution to this, right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
