adamsaghy commented on code in PR #5041:
URL: https://github.com/apache/fineract/pull/5041#discussion_r2362788929
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanBalanceService.java:
##########
@@ -93,20 +102,32 @@ public boolean isOverPaid(final Loan loan) {
}
public void updateLoanSummaryDerivedFields(final Loan loan) {
+ updateLoanSummaryDerivedFieldsInternal(loan, false);
+ }
+
+ public void updateLoanSummaryDerivedFieldsViaPersistence(final Loan loan) {
+ updateLoanSummaryDerivedFieldsInternal(loan, true);
+ }
+
+ private void updateLoanSummaryDerivedFieldsInternal(final Loan loan, final
boolean viaPersistence) {
flushModeHandler.withFlushMode(FlushModeType.COMMIT, () -> {
if (loan.isNotDisbursed()) {
if (loan.getSummary() != null) {
loan.getSummary().zeroFields();
}
loan.setTotalOverpaid(null);
} else {
- refreshSummaryAndBalancesForDisbursedLoan(loan);
+ refreshSummaryAndBalancesForDisbursedLoanInternal(loan,
viaPersistence);
}
});
}
public void refreshSummaryAndBalancesForDisbursedLoan(final Loan loan) {
- final Money overpaidBy = calculateTotalOverpayment(loan);
+ refreshSummaryAndBalancesForDisbursedLoanInternal(loan, false);
+ }
+
+ private void refreshSummaryAndBalancesForDisbursedLoanInternal(final Loan
loan, final boolean viaPersistence) {
+ final Money overpaidBy = viaPersistence ?
calculateTotalOverpaymentViaPersistence(loan) : calculateTotalOverpayment(loan);
Review Comment:
I dont think we should maintain two versions... use only 1 which fetches the
required transactions.
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanBalanceService.java:
##########
@@ -130,14 +156,23 @@ private Money calculateTotalRecoveredPayments(Loan loan) {
}
public void updateLoanOutstandingBalances(Loan loan) {
- Money outstanding = Money.zero(loan.getCurrency());
final List<LoanTransaction> loanTransactions = new ArrayList<>();
for (final LoanTransaction transaction : loan.getLoanTransactions()) {
if (transaction.isNotReversed() &&
!transaction.isNonMonetaryTransaction()) {
loanTransactions.add(transaction);
}
}
loanTransactions.sort(LoanTransactionComparator.INSTANCE);
+ updateLoanOutstandingBalancesInternal(loan, loanTransactions);
+ }
+
+ private void updateLoanOutstandingBalancesViaPersistence(final Loan loan) {
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
