mariiaKraievska commented on code in PR #5041:
URL: https://github.com/apache/fineract/pull/5041#discussion_r2366336088
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanBalanceService.java:
##########
@@ -50,6 +50,15 @@ public class LoanBalanceService {
private final LoanTransactionRepository loanTransactionRepository;
public Money calculateTotalOverpayment(final Loan loan) {
Review Comment:
The point is that currently calculateTotalOverpayment calculates data based
on loan.getLoanTransactions(). If we remove the calculateTotalOverpayment
method and replace it with calculateTotalOverpaymentViaPersistence, this will
entail changes in all services that currently add transactions to
loan.loanTransactions (call the loan.addLoanTransaction() method, and there are
61 usages of this. As far as I understand we have separate tasks for this).
Therefore, I focused on targeted changes related to transaction processors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
