mariiaKraievska commented on code in PR #5041:
URL: https://github.com/apache/fineract/pull/5041#discussion_r2366339974
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -290,11 +291,12 @@ public Pair<ChangedTransactionDetail,
ProgressiveLoanInterestScheduleModel> repr
}
@Override
- public ChangedTransactionDetail reprocessLoanTransactions(LocalDate
disbursementDate, List<LoanTransaction> loanTransactions,
- MonetaryCurrency currency, List<LoanRepaymentScheduleInstallment>
installments, Set<LoanCharge> charges) {
+ public ChangedTransactionDetail reprocessLoanTransactions(LocalDate
disbursementDate, List<LoanTransaction> loanTransactionsToReprocess,
+ MonetaryCurrency currency, List<LoanRepaymentScheduleInstallment>
installments, Set<LoanCharge> charges,
+ final List<LoanTransaction> loanTransactions) {
LocalDate currentDate = DateUtils.getBusinessLocalDate();
Pair<ChangedTransactionDetail, ProgressiveLoanInterestScheduleModel>
result = reprocessProgressiveLoanTransactions(disbursementDate,
- currentDate, loanTransactions, currency, installments,
charges);
+ currentDate, loanTransactionsToReprocess, currency,
installments, charges, loanTransactions);
Review Comment:
We have a _reprocessParticularTransactions_ method, which in turn uses
_reprocessLoanTransactions_, it passes certain specific transactions as the
loanTransactionsToReprocess parameter. However, during reprocessing, we also
need all loan transactions for certain calculations, so I introduced a new
loanTransactions parameter that contains all loan transactions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
