mariiaKraievska commented on code in PR #5041:
URL: https://github.com/apache/fineract/pull/5041#discussion_r2366344995
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/ReprocessLoanTransactionsServiceImpl.java:
##########
@@ -219,7 +217,7 @@ private ChangedTransactionDetail
reprocessTransactionsAndFetchChangedTransaction
final List<LoanTransaction> loanTransactions) {
final ChangedTransactionDetail changedTransactionDetail =
loanTransactionProcessingService.reprocessLoanTransactions(
loan.getTransactionProcessingStrategyCode(),
loan.getDisbursementDate(), loanTransactions, loan.getCurrency(),
- loan.getRepaymentScheduleInstallments(),
loan.getActiveCharges());
+ loan.getRepaymentScheduleInstallments(),
loan.getActiveCharges(), loan.getLoanTransactions());
Review Comment:
I tried to do so. But here is the same problem as above, connected to
calling the loan.addLoanTransaction() method in services.
The challenge:
There are many places where we:
1. First add new transaction to loan.loanTransactions
2. Call reprocessing methods
3. Only after that persist this new transaction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
