SteNicholas commented on a change in pull request #139:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/139#discussion_r840323877
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultDeploymentValidator.java
##########
@@ -145,10 +146,29 @@
}
Configuration configuration = Configuration.fromMap(confMap);
- if (job.getUpgradeMode() == UpgradeMode.LAST_STATE
- && !FlinkUtils.isKubernetesHAActivated(configuration)) {
- return Optional.of(
- "Job could not be upgraded with last-state while
Kubernetes HA disabled");
+ if (job.getUpgradeMode() == UpgradeMode.LAST_STATE) {
+ if (!FlinkUtils.isKubernetesHAActivated(configuration)) {
+ return Optional.of(
+ "Job could not be upgraded with last-state while
Kubernetes HA disabled");
+ } else if (!configuration.containsKey(
+
ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL.key())
+ || configuration
+
.get(ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL)
+ .compareTo(
+ configuration.get(
+
ExecutionCheckpointingOptions
+
.MIN_PAUSE_BETWEEN_CHECKPOINTS))
Review comment:
@gyfora, this check refers to the logic in
`CheckpointConfig#setCheckpointInterval` which compares to the
`MINIMAL_CHECKPOINT_TIME`, therefore this check is necessary.
@wangyang0918 WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
