gyfora commented on a change in pull request #139:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/139#discussion_r841082985
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentController.java
##########
@@ -114,6 +115,10 @@ public DeleteControl cleanup(FlinkDeployment flinkApp,
Context context) {
ReconciliationUtils.updateForReconciliationError(flinkApp,
validationError.get());
return ReconciliationUtils.toUpdateControl(
operatorConfiguration, originalCopy, flinkApp, false);
+ } else if (flinkApp.getSpec()
+ .getFlinkConfiguration()
+
.containsKey(ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL.key())) {
+
FlinkUtils.setCheckpointingInterval(originalCopy.getSpec().getFlinkConfiguration());
Review comment:
We should simply add this logic to the FlinkConfigBuilder instead of
modifying the spec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
