gyfora commented on a change in pull request #139:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/139#discussion_r841161449
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkConfigBuilder.java
##########
@@ -94,6 +97,17 @@ public FlinkConfigBuilder applyFlinkConfiguration() {
REST_SERVICE_EXPOSED_TYPE,
KubernetesConfigOptions.ServiceExposedType.ClusterIP);
}
+
+ // With last-state upgrade mode, set the default value of
'execution.checkpointing.interval'
+ // to 5 minutes when HA is enabled.
+ if (spec.getJob() != null
+ && spec.getJob().getUpgradeMode() == UpgradeMode.LAST_STATE
+ && FlinkUtils.isKubernetesHAActivated(effectiveConfig)
Review comment:
The HA config is already validated for last-state mode by the
DeploymentValidator, no need to check again here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
