Aitozi commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841081668
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/OperatorConfigOptions.java
##########
@@ -69,4 +69,10 @@
.defaultValue(Duration.ofSeconds(10))
.withDescription(
"The timeout for the observer to wait the flink
rest client to return.");
+
+ public static final ConfigOption<Duration> OPERATOR_CANCEL_JOB_TIMEOUT =
Review comment:
Before there is an hard code cancel job timeout is `1 min` for
application cluster
[here](https://github.com/apache/flink-kubernetes-operator/blob/ffe0d55613764a9dd768cc20f5d96da8154c0865/flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java#L187)
and the default client timeout is `10 s`. I'm not sure can we use the same
config to achieve the common purpose. But I can use client timeout now, leave
it to be improved later if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
