Aitozi commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841182486
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultSessionJobValidator.java
##########
@@ -17,12 +17,18 @@
package org.apache.flink.kubernetes.operator.validation;
+import org.apache.flink.kubernetes.operator.crd.FlinkDeployment;
import org.apache.flink.kubernetes.operator.crd.FlinkSessionJob;
import java.util.Optional;
/** Default validator implementation for {@link FlinkSessionJob}. */
-public class DefaultSessionJobValidator implements
FlinkResourceValidator<FlinkSessionJob> {
+public class DefaultSessionJobValidator implements FlinkResourceValidator {
Review comment:
I dropped the `DefaultSessionJobValidator`. Please see my last commit.
The webhook have not changed accordingly. I want to create another PR for it.
Not I use `validate(FlinkSessionJob sessionJob, Optional<FlinkDeployment>
session)` to validate the session job. It will check the relations of both. But
for webhook, it may not have access to the secondary resource, Maybe we could
only verify the target session job in the webhook and do the full validation in
the operator. what do you think of this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
