gyfora commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841166659
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultSessionJobValidator.java
##########
@@ -17,12 +17,18 @@
package org.apache.flink.kubernetes.operator.validation;
+import org.apache.flink.kubernetes.operator.crd.FlinkDeployment;
import org.apache.flink.kubernetes.operator.crd.FlinkSessionJob;
import java.util.Optional;
/** Default validator implementation for {@link FlinkSessionJob}. */
-public class DefaultSessionJobValidator implements
FlinkResourceValidator<FlinkSessionJob> {
+public class DefaultSessionJobValidator implements FlinkResourceValidator {
Review comment:
Now that we have both methods in the interface can we drop the
`DefaultSessionJobValidator` and just move the logic to the
`DefaultDeploymentValidator`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
