gaoyangxiaozhu commented on code in PR #6433:
URL: https://github.com/apache/incubator-gluten/pull/6433#discussion_r1677250354
##########
backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala:
##########
@@ -664,6 +665,15 @@ class ScalarFunctionsValidateSuite extends
FunctionsValidateTest {
}
}
+ test("Test sequence function") {
+ withSQLConf(("spark.sql.optimizer.excludedRules",
NullPropagation.ruleName)) {
Review Comment:
hey good question @PHILO-HE , actually the matter is `constant folding rule`
which should be removed from the `excludedRules`, so here is only use to
override and remove it from default test sql conf
https://github.com/apache/incubator-gluten/blob/main/backends-velox/src/test/scala/org/apache/gluten/execution/FunctionsValidateTest.scala#L44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
