gaoyangxiaozhu commented on code in PR #6433:
URL: https://github.com/apache/incubator-gluten/pull/6433#discussion_r1677653201
##########
backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala:
##########
@@ -664,6 +665,15 @@ class ScalarFunctionsValidateSuite extends
FunctionsValidateTest {
}
}
+ test("Test sequence function") {
+ withSQLConf(("spark.sql.optimizer.excludedRules",
NullPropagation.ruleName)) {
Review Comment:
hey @PHILO-HE, maybe you mis-understand here, I just removed `constant
folding rule` from `excludedRules` to make sure the rule can take effect (the
default spark behavior), so the result of the UT is computed actually by spark
and been put into `unsafeArray` with Alias Literal type to offload to gluten.
if put `constant folding rule` in `excludedRules`, it will try offload
`sequence` to velox and fallback due to unsupporetd function name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
