PHILO-HE commented on code in PR #6433:
URL: https://github.com/apache/incubator-gluten/pull/6433#discussion_r1677727658


##########
backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala:
##########
@@ -664,6 +665,15 @@ class ScalarFunctionsValidateSuite extends 
FunctionsValidateTest {
     }
   }
 
+  test("Test sequence function") {
+    withSQLConf(("spark.sql.optimizer.excludedRules", 
NullPropagation.ruleName)) {

Review Comment:
   @gaoyangxiaozhu, I see. I think it would be better to revise test name to 
the one like: "sequence function optimized by Spark constant folding"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to