gaoyangxiaozhu commented on code in PR #6433:
URL: https://github.com/apache/incubator-gluten/pull/6433#discussion_r1678809370
##########
gluten-core/src/main/java/org/apache/gluten/substrait/expression/ExpressionBuilder.java:
##########
@@ -215,6 +217,19 @@ public static LiteralNode makeLiteral(Object obj, TypeNode
typeNode) {
public static LiteralNode makeLiteral(Object obj, DataType dataType, Boolean
nullable) {
TypeNode typeNode = ConverterUtils.getTypeNode(dataType, nullable);
+ if (obj instanceof UnsafeArrayData) {
Review Comment:
em.. actually not sure, unless we sure the literal list type always be
`UnSafeArrayData`, but i am not sure right now.
Let's keep current change , and let me do follow up to check spark code to
see if can always move to `UnSafeArrayData`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
