NEUpanning commented on issue #8227: URL: https://github.com/apache/incubator-gluten/issues/8227#issuecomment-2556668249
@zhztheplayer Thank you for your idea. I'm trying to implement this solution, but I am struggling to design a new `collect_list` / `collect_set` that is both a `TypedImperativeAggregate` and compatible with Velox's `collect_list` / `collect_set`. For Velox's `BloomFilterAggregate`, the intermediate data type is `StringView`, which is compatible with Gluten's intermediate data type, `BINARY`. As a result, Gluten's `VeloxBloomFilterAggregate` only needs to implement serialization and deserialization methods for the intermediate data in a manner that is similar to Velox's `BloomFilterAggregate`. However, the intermediate data type for Velox's `collect_list` is `ARRAY`, which is not compatible with `BINARY`. It seems that this solution won't work unless we change the intermediate data type of one of them, similar to the current workaround where the intermediate data type of Gluten's `VeloxBloomFilterAggregate` is `ARRAY`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
