NEUpanning commented on issue #8227: URL: https://github.com/apache/incubator-gluten/issues/8227#issuecomment-2560592726
@zhztheplayer > Wanted to hear about your thoughts here but I was thinking we may still need to have typed-imperative versions of velox_collect_list / velox_collect_set. Because collect_list / collect_set will not be not compatible with velox_collect_list / velox_collect_set on their intermediate buffer serde protocals. Currently, Spark's collect_list/collect_set uses `UnsafeArrayData` as format for SerDe. If we utilize `UnsafeRowDeserializer` and `UnsafeRowFast` that are compatible with `UnsafeArrayData` format(BTW, they are also used in R2C and C2R) to do the SerDe in Velox, we will no longer need to maintain the rewrite rules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
