zhztheplayer commented on issue #8227: URL: https://github.com/apache/incubator-gluten/issues/8227#issuecomment-2560571869
@NEUpanning Looking good to me, thank for summarizing them up. BTW regarding `(c)`: > remove the rewrite rules for collect_list/collect_set in gluten Wanted to hear about your thoughts here but I was thinking we may still need to have typed-imperative versions of `velox_collect_list` / `velox_collect_set`. Because `collect_list` / `collect_set` will not be not compatible with `velox_collect_list` / `velox_collect_set` on their intermediate buffer serde protocals. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
