PHILO-HE commented on code in PR #10883:
URL:
https://github.com/apache/incubator-gluten/pull/10883#discussion_r2436647043
##########
dev/release/package-release.sh:
##########
Review Comment:
@zhztheplayer, could you please include the following changes? I have
applied these changes in the recently RC. It's for meeting the release
requirement (The approved release candidate will be directly converted to a
formal release. So "rc*" shouldn't be used in naming packaged folders).
```diff
diff --git a/dev/release/package-release.sh b/dev/release/package-release.sh
index ec18101ae..d60a14e78 100755
--- a/dev/release/package-release.sh
+++ b/dev/release/package-release.sh
@@ -53,11 +53,14 @@ for v in $SPARK_VERSIONS; do
done
SRC_ZIP="${TAG}.zip"
-SRC_DIR="incubator-gluten-${TAG_VERSION}"
+SRC_DIR="incubator-gluten-${RELEASE_VERSION}"
echo "Packaging source code..."
wget https://github.com/apache/incubator-gluten/archive/refs/tags/${SRC_ZIP}
unzip -q ${SRC_ZIP}
+
+# Rename folder to remove "rc*" for formal release.
+mv incubator-gluten-${TAG_VERSION} ${SRC_DIR}
tar -czf apache-gluten-${RELEASE_VERSION}-incubating-src.tar.gz ${SRC_DIR}
rm -r ${SRC_ZIP} ${SRC_DIR}
```
##########
docs/developers/HowToRelease.md:
##########
@@ -0,0 +1,76 @@
+---
+layout: page
+title: How to Release
+nav_order: 17
+parent: Getting-Started
Review Comment:
Please update accordingly. Thanks.
##########
docs/developers/HowToRelease.md:
##########
Review Comment:
Sounds good to me. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
