PHILO-HE commented on code in PR #10883: URL: https://github.com/apache/incubator-gluten/pull/10883#discussion_r2434748751
########## dev/release/package-release.sh: ########## @@ -15,7 +15,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -# Note: Manually create $GLUTEN_HOME/release/ and place the release JARs inside. +# Note: The script looks up the release JARs inside $GLUTEN_HOME/package/target/. Review Comment: @zhztheplayer, thank you for the reply. I am not sure if users really need to create an official-like release by themselves. In official release, we build Gluten for all supported Spark versions with all feature modules enabled, even though generally some of them are not enabled together by users (e.g., Celeborn and Uniffle). However, most Gluten users only focus on one specific Spark version, and some of the the feature modules, which means they just need a clear build guide, not a release guide. Users like cloud service providers may require building releases for multi-Spark-version support. But they likely maintain their own processes and scripts to customize releases for forked repositories, which I assume differs significantly from our official release process. If my understanding is correct, maybe we can focus only on the official release process, primarily for release managers' reference? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
