zhztheplayer commented on code in PR #10883: URL: https://github.com/apache/incubator-gluten/pull/10883#discussion_r2431873773
########## dev/release/package-release.sh: ########## @@ -15,7 +15,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -# Note: Manually create $GLUTEN_HOME/release/ and place the release JARs inside. +# Note: The script looks up the release JARs inside $GLUTEN_HOME/package/target/. Review Comment: Hi @PHILO-HE, > I have created one GHA job to build Gluten, and then upload the JARs. I believe there are two separate things we need: 1. Guide for user to create a release by themself ([RE50](https://community.apache.org/apache-way/apache-project-maturity-model.html#releases)) 2. Guide for release manager to publish a release (better to have?) For users, they don't usually have the immediate permission to run the GitHub Actions jobs. So we need provide a way for them to create the release artifacts from the source code. I can leave the `$GLUTEN_HOME/release/` solution unchanged but add an extra copy-paste step in the documentation. Does that make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
