zhztheplayer commented on code in PR #11249:
URL:
https://github.com/apache/incubator-gluten/pull/11249#discussion_r2588500876
##########
cpp/velox/memory/VeloxMemoryManager.cc:
##########
@@ -445,27 +445,11 @@ bool VeloxMemoryManager::tryDestructSafe() {
}
VeloxMemoryManager::~VeloxMemoryManager() {
- static const uint32_t kWaitTimeoutMs =
FLAGS_gluten_velox_async_timeout_on_task_stopping; // 30s by default
- uint32_t accumulatedWaitMs = 0UL;
bool destructed = false;
- for (int32_t tryCount = 0; accumulatedWaitMs < kWaitTimeoutMs; tryCount++) {
Review Comment:
Same comment here. We'd maintain a timeout so we won't hang forever by a
remaining allocation in Velox.
The final goal will be removing this wait mechanism and rely on
`Task::requestCancel` instead. So feel free to add a code comment marking this
is a workaround against an Issue from Velox if the lines might confuse you
already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
