rui-mo commented on code in PR #11249:
URL:
https://github.com/apache/incubator-gluten/pull/11249#discussion_r2589042375
##########
cpp/velox/memory/VeloxMemoryManager.cc:
##########
@@ -445,27 +445,11 @@ bool VeloxMemoryManager::tryDestructSafe() {
}
VeloxMemoryManager::~VeloxMemoryManager() {
- static const uint32_t kWaitTimeoutMs =
FLAGS_gluten_velox_async_timeout_on_task_stopping; // 30s by default
- uint32_t accumulatedWaitMs = 0UL;
bool destructed = false;
- for (int32_t tryCount = 0; accumulatedWaitMs < kWaitTimeoutMs; tryCount++) {
Review Comment:
@zhztheplayer Is this patch
(https://github.com/facebookincubator/velox/commit/059ffcbeac2523a5eade65007adf0319829a7c4e)
intended for the purpose you mentioned? I noticed the calling of cancel would
do nothing right now. If we proceed this way, it would differ a bit from
importing https://github.com/facebookincubator/velox/pull/14722 or customizing
buffered input in Gluten. However, the fix would become more like
https://github.com/facebookincubator/velox/pull/8205, which releases the load
through table scan's close.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
