zhztheplayer commented on code in PR #11249:
URL:
https://github.com/apache/incubator-gluten/pull/11249#discussion_r2591074396
##########
cpp/velox/memory/VeloxMemoryManager.cc:
##########
@@ -445,27 +445,11 @@ bool VeloxMemoryManager::tryDestructSafe() {
}
VeloxMemoryManager::~VeloxMemoryManager() {
- static const uint32_t kWaitTimeoutMs =
FLAGS_gluten_velox_async_timeout_on_task_stopping; // 30s by default
- uint32_t accumulatedWaitMs = 0UL;
bool destructed = false;
- for (int32_t tryCount = 0; accumulatedWaitMs < kWaitTimeoutMs; tryCount++) {
Review Comment:
By close / cancel (Velox PR 8205 / 14722 included) I think we are talking
about the same concept - to end the computation and release the resources
before the Velox task can be destructed. You can consider `requestCancel` a way
to ensure all the Velox `close` APIs are called. So I guess we are already on
the same page.
It was just worth noting this wait logic in `~VeloxMemoryManager` is only a
temporary solution for keeping the pools alive in case the operators were
halted too early without completing all the async operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
