Zouxxyy commented on PR #11358: URL: https://github.com/apache/incubator-gluten/pull/11358#issuecomment-3738483913
@rui-mo During our implementation of hybrid AGG (where a single AGG contains both partial-merge and complete modes), we discovered this issue: Inside `rewriteAggBufferAttributes`, the code compares `aggBufferAttrs` with `InputAttributes`, which is actually incorrect in Complete mode. However, since Spark + Gluten currently does not support having both partial-merge and complete functions simultaneously, the current code path will not trigger this scenario, and it's difficult to construct a unit test (UT) for it. Nevertheless, I think we can add this defensive code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
