Zouxxyy commented on code in PR #11358: URL: https://github.com/apache/incubator-gluten/pull/11358#discussion_r2682435619
########## backends-velox/src/main/scala/org/apache/gluten/execution/HashAggregateExecTransformer.scala: ########## Review Comment: > Why would this be called for the Complete mode, as `rowConstructNeeded()` returns false for it? As mentioned earlier, we implemented a hybrid AGG that contains both PartialMerge (or Final) and complete aggregation functions, and `rowConstructNeeded` is triggered as long as a PartialMerge (or Final) function is present. It won't be triggered for the now code, but I think we can add defensive code to handle this scenario in future implementations . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
