rui-mo commented on code in PR #11358: URL: https://github.com/apache/incubator-gluten/pull/11358#discussion_r2682591050
########## backends-velox/src/main/scala/org/apache/gluten/execution/HashAggregateExecTransformer.scala: ########## Review Comment: > rowConstructNeeded is triggered as long as a PartialMerge (or Final) function is present Are you referring to the modified code on your side, or the current Gluten code? > As mentioned earlier, we implemented a hybrid AGG that contains both PartialMerge (or Final) and complete aggregation functions Is there any plan to upstream this change to Gluten, or will it remain local to your side? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
