infvg commented on code in PR #11392:
URL:
https://github.com/apache/incubator-gluten/pull/11392#discussion_r2764660441
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -447,6 +452,22 @@ object VeloxConfig extends ConfigRegistry {
.longConf
.createWithDefault(4194304L)
+ val HASH_PROBE_BLOOM_FILTER_PUSHDOWN_MAX_SIZE =
+
buildConf("spark.gluten.sql.columnar.backend.velox.hashProbe.bloomFilterPushdown.maxSize")
+ .doc("The maximum byte size of Bloom filter that can be generated from
hash probe. When " +
+ "set to 0, no Bloom filter will be generated. To achieve optimal
performance, this should" +
+ " not be too larger than the CPU cache size on the host.")
+ .bytesConf(ByteUnit.BYTE)
+ .createWithDefault(0)
Review Comment:
Velox has the default set to true:
https://github.com/facebookincubator/velox/blob/10bdc0688f892dcda83cfbcf723f656ba5e1e6b4/velox/core/QueryConfig.h#L1304-L1308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
