yaooqinn opened a new pull request, #11837: URL: https://github.com/apache/gluten/pull/11837
## What changes were proposed in this pull request? Add `ignoreNulls` parameter to `VeloxCollectList`/`VeloxCollectSet` to support Spark's RESPECT NULLS syntax (SPARK-55256). When `ignoreNulls=false`, null elements are included in the collected array. ### Changes: - **`VeloxCollectSet`/`VeloxCollectList`**: Accept `ignoreNulls` parameter (default `true` for backward compatibility). - **`CollectRewriteRule`**: Propagates `ignoreNulls` from Spark's `CollectList`/`CollectSet` using reflection, making it backward-compatible with Spark versions that don't have `ignoreNulls`. ### Related: - Velox PR: https://github.com/facebookincubator/velox/pull/16933 (collect_list RESPECT NULLS) - Velox PR: https://github.com/facebookincubator/velox/pull/16416 (collect_set RESPECT NULLS, merged) - Spark JIRA: SPARK-55256 ## How was this patch tested? CI validation. The default behavior (`ignoreNulls=true`) is unchanged, ensuring backward compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
