yaooqinn commented on PR #11837: URL: https://github.com/apache/gluten/pull/11837#issuecomment-4142307902
Thanks @zhouyuan! This Gluten PR uses `DeclarativeAggregate` (Scala-based array operations via `VeloxCollect`) — it does **not** call Velox's native `collect_set`/`collect_list` aggregate functions. So it's independent of the Velox-side changes and should work with any Velox version. That said, I'll verify compatibility: - Velox PR #16416 (collect_set RESPECT NULLS) is already merged to upstream main - Velox PR #16933 (collect_list RESPECT NULLS) is still in review I can create a combined Velox branch with both patches if needed for CI testing. The IBM/velox `dft-2026_03_24` branch should already have the collect_set changes since they're in upstream main — let me check if it needs the collect_list patch as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
