yaooqinn commented on PR #11837: URL: https://github.com/apache/gluten/pull/11837#issuecomment-4142546032
Attempted local verification with Velox patches (collect_set from upstream main + collect_list from PR #16933). The Velox native lib (libvelox.a) builds successfully with both patches. However, full Gluten build cannot complete locally due to pre-existing Scala version mismatch in cached Maven artifacts (unrelated to this PR). The VeloxCollect changes are purely Scala/JVM-side (DeclarativeAggregate), so they're independent of the Velox native collect_set/collect_list functions. CI will provide the definitive verification. @zhouyuan The native Velox patches for collect_set/collect_list add `Aggregate::setConstantInputs()` for the boolean ignoreNulls parameter, but since VeloxCollect uses Scala-based array operations, it doesn't need those native changes. The Gluten PR works with any Velox version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
