acvictor commented on code in PR #11861:
URL: https://github.com/apache/gluten/pull/11861#discussion_r3044141782
##########
backends-velox/src/main/scala/org/apache/gluten/metrics/MetricsUtil.scala:
##########
@@ -364,7 +364,7 @@ object MetricsUtil extends Logging {
}
} catch {
case e: Exception =>
- logWarning(s"Updating native metrics failed due to ${e.getCause}.")
+ logError(s"Updating native metrics failed due to ${e.getCause}." + e)
Review Comment:
@zhztheplayer removing the try-catch required fixes in a few more places but
all UTs are passing now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
