acvictor commented on code in PR #11861:
URL: https://github.com/apache/gluten/pull/11861#discussion_r3044293201
##########
backends-velox/src/main/scala/org/apache/gluten/metrics/MetricsUtil.scala:
##########
@@ -364,7 +364,7 @@ object MetricsUtil extends Logging {
}
} catch {
case e: Exception =>
- logWarning(s"Updating native metrics failed due to ${e.getCause}.")
+ logError(s"Updating native metrics failed due to ${e.getCause}." + e)
Review Comment:
@rui-mo these were the only test failures
```
- rewrite unbounded window *** FAILED ***
org.apache.spark.SparkException: Job aborted due to stage failure: Task 0
in stage 104.0 failed 1 times, most recent failure: Lost task 0.0 in stage
104.0 (TID 66) (3e255c7568a5 executor driver): java.lang.NullPointerException:
Cannot invoke "org.apache.gluten.substrait.JoinParams.postProjectionNeeded()"
because "joinParams" is null
at
org.apache.gluten.metrics.JoinMetricsUpdaterBase.updateJoinMetrics(JoinMetricsUpdater.scala:49)
at
org.apache.gluten.metrics.MetricsUtil$.updateTransformerMetricsInternal(MetricsUtil.scala:268)
at
org.apache.gluten.metrics.MetricsUtil$.$anonfun$genMetricsUpdatingFunction$3(MetricsUtil.scala:357)
at
org.apache.gluten.metrics.MetricsUtil$.$anonfun$genMetricsUpdatingFunction$3$adapted(MetricsUtil.scala:344)
at
org.apache.gluten.backendsapi.velox.VeloxIteratorApi.$anonfun$genFinalStageIterator$2(VeloxIteratorApi.scala:282)
```
```
- test cross join *** FAILED ***
org.apache.spark.SparkException: Job aborted due to stage failure: Task 0
in stage 948.0 failed 1 times, most recent failure: Lost task 0.0 in stage
948.0 (TID 812) (3e255c7568a5 executor driver): java.lang.NullPointerException:
Cannot invoke "org.apache.gluten.substrait.JoinParams.postProjectionNeeded()"
because "joinParams" is null
at
org.apache.gluten.metrics.JoinMetricsUpdaterBase.updateJoinMetrics(JoinMetricsUpdater.scala:49)
at
org.apache.gluten.metrics.MetricsUtil$.updateTransformerMetricsInternal(MetricsUtil.scala:268)
at
org.apache.gluten.metrics.MetricsUtil$.$anonfun$genMetricsUpdatingFunction$3(MetricsUtil.scala:357)
at
org.apache.gluten.metrics.MetricsUtil$.$anonfun$genMetricsUpdatingFunction$3$adapted(MetricsUtil.scala:344)
at
org.apache.gluten.backendsapi.velox.VeloxIteratorApi.$anonfun$genFinalStageIterator$2(VeloxIteratorApi.scala:282)
```
```
- Columnar cartesian product with other join *** FAILED ***
org.apache.spark.SparkException: Job aborted due to stage failure: Task 0
in stage 1044.0 failed 1 times, most recent failure: Lost task 0.0 in stage
1044.0 (TID 877) (3e255c7568a5 executor driver):
org.apache.gluten.exception.GlutenException:
org.apache.gluten.exception.GlutenException: Error during calling Java code
from native code: java.lang.NullPointerException: Cannot invoke
"org.apache.gluten.substrait.JoinParams.postProjectionNeeded()" because
"joinParams" is null
at
org.apache.gluten.metrics.JoinMetricsUpdaterBase.updateJoinMetrics(JoinMetricsUpdater.scala:49)
at
org.apache.gluten.metrics.MetricsUtil$.updateTransformerMetricsInternal(MetricsUtil.scala:268)
at
org.apache.gluten.metrics.MetricsUtil$.$anonfun$updateTransformerMetricsInternal$2(MetricsUtil.scala:310)
at
org.apache.gluten.metrics.MetricsUtil$.$anonfun$updateTransformerMetricsInternal$2$adapted(MetricsUtil.scala:302)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
