rui-mo commented on code in PR #11861:
URL: https://github.com/apache/gluten/pull/11861#discussion_r3044159269
##########
backends-velox/src/main/scala/org/apache/gluten/metrics/MetricsUtil.scala:
##########
@@ -364,7 +364,7 @@ object MetricsUtil extends Logging {
}
} catch {
case e: Exception =>
- logWarning(s"Updating native metrics failed due to ${e.getCause}.")
+ logError(s"Updating native metrics failed due to ${e.getCause}." + e)
Review Comment:
@acvictor what kinds of failures are you seeing after removing the
try-catch? As I recall, it was added to guard against cases where the metrics
updater isn’t properly implemented for certain operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
