philo-he commented on code in PR #12158:
URL: https://github.com/apache/gluten/pull/12158#discussion_r3325721434
##########
cpp/velox/operators/functions/RegistrationAllFunctions.cc:
##########
@@ -76,6 +77,14 @@ void registerFunctionOverwrite() {
kRowConstructorWithAllNull,
std::make_unique<RowConstructorWithNullCallToSpecialForm>(kRowConstructorWithAllNull));
+ // Register math functions that are present in the prestosql implementation
+ // but not yet in the sparksql registry. These are semantically identical
+ // to Spark's behavior for the same names.
Review Comment:
Thanks for the PR. Would it make sense to refactor the Velox code, moving
these functions to a common location and registering them in Spark's
`registerMathFunctions`, provided we verify their implementations are identical?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
