philo-he commented on code in PR #12158:
URL: https://github.com/apache/gluten/pull/12158#discussion_r3327049145
##########
cpp/velox/operators/functions/RegistrationAllFunctions.cc:
##########
@@ -76,6 +77,14 @@ void registerFunctionOverwrite() {
kRowConstructorWithAllNull,
std::make_unique<RowConstructorWithNullCallToSpecialForm>(kRowConstructorWithAllNull));
+ // Register math functions that are present in the prestosql implementation
+ // but not yet in the sparksql registry. These are semantically identical
+ // to Spark's behavior for the same names.
Review Comment:
@brijrajk, thank you for the clarification. I was just aware of the above
discussion. That makes sense.
Perhaps, you may set the Velox PR ID in the following position for verifying
that PR on Gluten side.
https://github.com/apache/gluten/blob/ce6e16fe8f37d97bdc1296eef222a5b97af8bd75/ep/build-velox/src/get-velox.sh#L28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
