brijrajk commented on code in PR #12158:
URL: https://github.com/apache/gluten/pull/12158#discussion_r3327847872
##########
cpp/velox/operators/functions/RegistrationAllFunctions.cc:
##########
@@ -76,6 +77,14 @@ void registerFunctionOverwrite() {
kRowConstructorWithAllNull,
std::make_unique<RowConstructorWithNullCallToSpecialForm>(kRowConstructorWithAllNull));
+ // Register math functions that are present in the prestosql implementation
+ // but not yet in the sparksql registry. These are semantically identical
+ // to Spark's behavior for the same names.
Review Comment:
Done — set UPSTREAM_VELOX_PR_ID=17648 in get-velox.sh so CI builds Gluten
with
[facebookincubator/velox#17648](https://github.com/facebookincubator/velox/pull/17648)
applied and validates the five Scala integration tests natively. Also added ln
back with an edge-case check verifying ln(0) and ln(-1) return null. Will clear
UPSTREAM_VELOX_PR_ID and mark the PR ready once that Velox change lands in
Gluten.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
