brijrajk opened a new pull request, #12199: URL: https://github.com/apache/gluten/pull/12199
## What changes are proposed in this pull request? The `atan2` test in `MathFunctionsValidateSuite` was marked `ignore` in 2023 after a result mismatch — Velox's implementation was using `std::atan2` directly, which handles `-0` inputs differently from Spark's `Math.atan2(y + 0.0, x + 0.0)`. That was fixed upstream in oap-project/velox#263, which added `sparksql::Atan2Function` that normalises `-0` inputs to match Spark's exact behaviour. The `ignore` annotation was never removed after the fix landed, leaving a valid test permanently skipped. This PR re-enables the test by changing `ignore` to `test`. Also promotes `MathFunctionsValidateSuite` from `abstract class` to `class` — a leftover from PR #11756 (RAS removal) which deleted the only concrete subclasses but missed this suite (the same fix was correctly applied to `DateFunctionsValidateSuite` in that PR). ANSI mode is disabled for Spark 4 compatibility, consistent with the approach taken in PR #12158 which adds further tests to this same suite. ## How was this patch tested? The re-enabled test runs `SELECT atan2(double_field1, 0) from datatab limit 1` and verifies native execution via `checkGlutenPlan[ProjectExecTransformer]`, comparing results against vanilla Spark. ## Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude (Anthropic) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
