brijrajk commented on PR #12199: URL: https://github.com/apache/gluten/pull/12199#issuecomment-4587372757
@philo-he — tagging you as you reviewed a related change in PR #12158 which also touches `MathFunctionsValidateSuite`. This PR is **independent** of #12158 and can be merged directly without waiting for it. The three changes here (abstract→class, ANSI disable, atan2 un-ignore) are all self-contained correctness fixes with no external dependencies. PR #12158 (currently draft, pending [facebookincubator/velox#17648](https://github.com/facebookincubator/velox/pull/17648)) will be rebased on top of this once it merges, so the duplicate `abstract→class` and ANSI fixes are resolved cleanly at that point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
