philo-he commented on code in PR #12199:
URL: https://github.com/apache/gluten/pull/12199#discussion_r3337704712
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -66,7 +66,15 @@ class MathFunctionsValidateSuiteAnsiOn extends
FunctionsValidateSuite {
}
}
-abstract class MathFunctionsValidateSuite extends FunctionsValidateSuite {
+class MathFunctionsValidateSuite extends FunctionsValidateSuite {
+
+ // Disable ANSI mode: Spark 4 enables it by default, which wraps math
functions
+ // in ANSI check nodes and prevents ProjectExecTransformer from being the
top-level
+ // plan node. ANSI-specific behaviour is tested in
MathFunctionsValidateSuiteAnsiOn.
+ override protected def sparkConf: SparkConf = {
+ super.sparkConf
+ .set(SQLConf.ANSI_ENABLED.key, "false")
Review Comment:
@brijrajk, my understanding is that the following Spark code reads this
environment variable to determine the default value of the ANSI config. It only
influences the default — if the user or test code sets the ANSI config
explicitly, that setting takes precedence. Could you double confirm if we still
need an explicit setting? Thank you.
https://github.com/apache/spark/blob/224231815105f6c0f333e866ef50c48810720f37/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala#L5180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
