Copilot commented on code in PR #12625:
URL: https://github.com/apache/gluten/pull/12625#discussion_r3649715267
##########
cpp/velox/CMakeLists.txt:
##########
@@ -443,8 +466,8 @@ if(DEFINED VCPKG_INSTALLED_DIR
)
target_link_libraries(
velox
- PRIVATE ${VCPKG_INSTALLED_DIR}/${VCPKG_TRIPLET_DIR}/lib/libthriftcpp2.a
-
${VCPKG_INSTALLED_DIR}/${VCPKG_TRIPLET_DIR}/lib/libthriftprotocol.a)
+ PUBLIC ${VCPKG_INSTALLED_DIR}/${VCPKG_TRIPLET_DIR}/lib/libthriftcpp2.a
+ ${VCPKG_INSTALLED_DIR}/${VCPKG_TRIPLET_DIR}/lib/libthriftprotocol.a)
Review Comment:
This vcpkg thrift link path depends on `VCPKG_TRIPLET_DIR`, but that
directory is inferred from `CMAKE_SYSTEM_PROCESSOR` earlier in the file. If the
active vcpkg triplet differs (custom triplet, renamed triplet, etc.), the
lookup will fail even though `VCPKG_TARGET_TRIPLET`/`$ENV{VCPKG_TRIPLET}` is
available when the vcpkg toolchain is in use. Prefer deriving
`VCPKG_TRIPLET_DIR` from the actual triplet variable and only falling back to
the processor-based guess when unavailable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
