Copilot commented on code in PR #12625:
URL: https://github.com/apache/gluten/pull/12625#discussion_r3650240473
##########
dev/vcpkg/ports/arrow/usage:
##########
@@ -0,0 +1,4 @@
+The package arrow provides CMake targets:
+
+ find_package(Arrow CONFIG REQUIRED)
+ target_link_libraries(main PRIVATE
"$<IF:$<BOOL:${ARROW_BUILD_STATIC}>,Arrow::arrow_static,Arrow::arrow_shared>")
Review Comment:
`usage` references `${ARROW_BUILD_STATIC}`, but this variable is not defined
in typical consumers’ CMake projects (it’s an Arrow build option, not part of
the exported package config). The snippet as written is likely to always choose
the shared target or behave unexpectedly. Prefer selecting the target by
checking which one exists.
##########
dev/vcpkg/ports/arrow/usage-parquet:
##########
@@ -0,0 +1,3 @@
+
+ find_package(Parquet CONFIG REQUIRED)
+ target_link_libraries(main PRIVATE
"$<IF:$<BOOL:${ARROW_BUILD_STATIC}>,Parquet::parquet_static,Parquet::parquet_shared>")
Review Comment:
`usage-parquet` references `${ARROW_BUILD_STATIC}`, which won’t be defined
in consumers’ CMake projects. Prefer choosing the Parquet target by checking
which imported target exists.
##########
dev/vcpkg/ports/arrow/usage-flight:
##########
@@ -0,0 +1,3 @@
+
+ find_package(ArrowFlight CONFIG REQUIRED)
+ target_link_libraries(main PRIVATE
"$<IF:$<BOOL:${ARROW_BUILD_STATIC}>,ArrowFlight::arrow_flight_static,ArrowFlight::arrow_flight_shared>")
Review Comment:
`usage-flight` references `${ARROW_BUILD_STATIC}`, which won’t be defined in
consumers’ CMake projects. Prefer choosing the ArrowFlight target by checking
which imported target exists.
##########
dev/vcpkg/ports/arrow/usage-flightsql:
##########
@@ -0,0 +1,3 @@
+
+ find_package(ArrowFlightSql CONFIG REQUIRED)
+ target_link_libraries(main PRIVATE
"$<IF:$<BOOL:${ARROW_BUILD_STATIC}>,ArrowFlightSql::arrow_flight_sql_static,ArrowFlightSql::arrow_flight_sql_shared>")
Review Comment:
`usage-flightsql` references `${ARROW_BUILD_STATIC}`, which won’t be defined
in consumers’ CMake projects. Prefer choosing the ArrowFlightSql target by
checking which imported target exists.
##########
dev/vcpkg/ports/arrow/usage-acero:
##########
@@ -0,0 +1,3 @@
+
+ find_package(ArrowAcero CONFIG REQUIRED)
+ target_link_libraries(main PRIVATE
"$<IF:$<BOOL:${ARROW_BUILD_STATIC}>,ArrowAcero::arrow_acero_static,ArrowAcero::arrow_acero_shared>")
Review Comment:
`usage-acero` references `${ARROW_BUILD_STATIC}`, which won’t be defined in
consumers’ CMake projects. Prefer choosing the ArrowAcero target by checking
which imported target exists.
##########
dev/vcpkg/ports/arrow/usage-dataset:
##########
@@ -0,0 +1,3 @@
+
+ find_package(ArrowDataset CONFIG REQUIRED)
+ target_link_libraries(main PRIVATE
"$<IF:$<BOOL:${ARROW_BUILD_STATIC}>,ArrowDataset::arrow_dataset_static,ArrowDataset::arrow_dataset_shared>")
Review Comment:
`usage-dataset` references `${ARROW_BUILD_STATIC}`, which won’t be defined
in consumers’ CMake projects. Prefer choosing the ArrowDataset target by
checking which imported target exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
